h #4058
h #4058
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the implementation! The Sum component works correctly and handles all the requirements perfectly.
However, one change is needed to meet the project's coding standards. In src/components/Sum/Sum.jsx, the text inside the <p> tag violates a checklist item. Please use a single template literal for the entire string, like this:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>This change is required by [CHECKLIST ITEM #2]. After you make this small adjustment, your solution will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| export const Sum = ({ a = 0, b = 0 }) => { | ||
| return ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This implementation works, but it doesn't follow the code style required by the task. This violates checklist item #2: 'Use string interpolation inside tag content'. The text inside the <p> tag should be wrapped in a single template literal ({...}) for better readability, as shown in the checklist's 'GOOD EXAMPLE'.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work addressing the feedback from the last review! Your solution now meets all the task requirements, and I am happy to approve it. The Sum component correctly uses a single template literal, and all component instances are properly configured in App.jsx. Your code is clean, correct, and demonstrates a solid understanding of the concepts. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://Vasyl-Levytskiy.github.io/react_sum/